-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate annual limit #2002
Conversation
🧪 Review environmenthttps://22lrohbkfjmezcsth4invhbamu0dccyg.lambda-url.ca-central-1.on.aws/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested locally and in the review app.
✅ Annual limit error messages work
✅ Annual limit error messages take precedence over daily limit messages
✅ Daily limit messages still display when the annual limit hasn't been hit yet.
This reverts commit d3887e5.
Summary | Résumé
This PR adds annual-limit checking to bulk sends. A follow-up PR will be made to address one-off sends in coordination with API changes being currently made.
Test instructions | Instructions pour tester la modification
Pre-setup:
Scenarios
User attempts to send more EMAILS than DAILY limit allows
User attempts to send more EMAILS than ANNUAL limit allows